Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ignoreSignatures functionality #1375

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Kevin-Molina
Copy link
Contributor

@Kevin-Molina Kevin-Molina commented Jul 12, 2024

Melange Pull Request Template

Expose ignoreSignatures functionality from apko to melange CLI clients.
Follow up for this PR: chainguard-dev/apko#1179

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes: I've run the full test suite locally without issue, but do not see wolfi as an E2E test case, so leaving this unchecked as unable to verify.

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes: E2E test suite passes. Was also able to build an custom APK locally without issues.

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes: Linter checks passed locally as well

Signed-off-by: Kevin-Molina <kevin.molina@csu.fullerton.edu>
@imjasonh imjasonh merged commit 3c2956a into chainguard-dev:main Jul 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants