Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): Use contextdir instead of destdir in a few places #1376

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

EyeCantCU
Copy link
Member

A few of these pipelines could otherwise be used in subpackages if they defaulted to contextdir instead of destdir. I'd imagine they already may be used in some, but no-op

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

A few of these pipelines could otherwise be used in subpackages if
they defaulted to contextdir instead of destdir. I'd imagine they
already may be used in some, but no-op

Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
@imjasonh imjasonh enabled auto-merge July 13, 2024 02:25
@imjasonh imjasonh merged commit 2f1e784 into main Jul 13, 2024
29 checks passed
@imjasonh imjasonh deleted the use-contextdir branch July 13, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants