fix(sca): Correctly check for existing Ruby runtime dependency #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Python, we can get away with checking for the "python" prefix in the package name as all other Python packages are prefixed with py<X.Y> instead of "python". For Ruby however, main Ruby packages follow a "ruby-<X.Y>" syntax and Ruby packages are "ruby<X.Y>" This addresses the above by checking for "ruby-" instead of "ruby". In case a package explicitly sets "ruby" as a runtime dependency to pull in the latest version, we just skip over it Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
jdolitsky
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Python, we can get away with checking for the "python" prefix in the package name as all other Python packages are prefixed with py<X.Y> instead of "python". For Ruby however, main Ruby packages follow a "ruby-<X.Y>" syntax and Ruby packages are "ruby<X.Y>"
This addresses the above by checking for "ruby-" instead of "ruby". In case a package explicitly sets "ruby" as a runtime dependency to pull in the latest version, we just skip over it
SCA Changes
Notes: Ran against packages without a versioned Ruby rt dep, ran with it set, and ran with just
rubyset