feat(pipelines/split): Support overriding source package #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjohnsonjr
previously approved these changes
Sep 3, 2024
|
I need to clean this up, I'd rather it take the package name, and when we pass ./melange-out instead of /home/build/melange-out, it breaks everything |
EyeCantCU
changed the title
Currently, our split pipelines only support splitting targets from the main package in destdir. There are cases where this behavior could be useful for subpackages I.E., minizip is built as part of the zlib packaging process as a subpackage. As a result, it includes development headers. As we can now voerride the source directory as ./melange-out/minizip, we can provide a minizip-dev subpackage without bundling it in zlib-dev Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
Signed-off-by: srishtih <srishti.hegde.sh@gmail.com>
paths Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
Thanks NVIDIA Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
NVIDIA Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
EyeCantCU
force-pushed
the
split-packagedir
branch
from
bdf4c24
to
eb213a1
Compare
jdolitsky
approved these changes
Sep 4, 2024
EyeCantCU
added a commit
that referenced
this pull request
Sep 5, 2024
/usr/local/*/lib64 was added to accomodate splitting away libraries used for development. This was incorrect. Now ALL libraries in /usr/local/*/lib64 get split away This fixes that and removes the behavior. We add `usr/` to library paths and that is sufficient for what we need Broken behavior introduced by me here: #1472 Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our split pipelines only support splitting targets from the main package in destdir. There are cases where this behavior could be useful for subpackages
I.E., minizip is built as part of the zlib packaging process as a subpackage. As a result, it includes development headers. As we can now override the source package, we can provide a minizip-dev subpackage without bundling it in zlib-dev
Example: