Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qemu): fix failing test pipeline when using qemu runner #1565

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

89luca89
Copy link
Contributor

@89luca89 89luca89 commented Oct 16, 2024

Until now melange test was failing with QEMU runners
This fixes the behaviour thanks to the investigation of @maxgio92 👍

EDIT: depends on wolfi-dev/os#30922

Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
@maxgio92
Copy link
Contributor

Thanks @89luca89! LGTM

imjasonh
imjasonh previously approved these changes Oct 16, 2024
@imjasonh imjasonh enabled auto-merge October 16, 2024 14:14
@cpanato cpanato disabled auto-merge October 16, 2024 14:16
@cpanato
Copy link
Member

cpanato commented Oct 16, 2024

@89luca89 some lint

diff --git a/pkg/build/test.go b/pkg/build/test.go
index 4aa7a2b..83c769a 100644
--- a/pkg/build/test.go
+++ b/pkg/build/test.go
@@ -350,7 +350,6 @@ func (t *Test) TestPackage(ctx context.Context) error {
 		}...)
 	}
 
-
 	// Filter out any subpackages with false If conditions.
 	t.Configuration.Subpackages = slices.DeleteFunc(t.Configuration.Subpackages, func(sp config.Subpackage) bool {
 		result, err := shouldRun(sp.If)
chainguard-dev/melange is incorrectly formatted. Please run goimports.

Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
@89luca89
Copy link
Contributor Author

Just fixed now 👍

@89luca89 89luca89 requested a review from imjasonh October 16, 2024 14:18
@89luca89 89luca89 enabled auto-merge October 16, 2024 14:18
@89luca89 89luca89 requested a review from cpanato October 16, 2024 14:18
@89luca89 89luca89 merged commit 776add0 into chainguard-dev:main Oct 16, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants