Git data fallbacks #1587
Merged
Git data fallbacks #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the CWD of the melange process. Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
imjasonh
previously approved these changes
Oct 22, 2024
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
luhring
force-pushed
the
git-data-fallbacks
branch
from
90559d0 to
aa8cda2
Compare
imjasonh
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves Melange builds + SBOM generation in two ways:
"unknown"). In a future PR, we might introduce some sort of "strict" flag that get Melange to fail if the correct (non-fallback) values aren't all available.