-
Notifications
You must be signed in to change notification settings - Fork 160
RFC: Source fetch from melange #2170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justinvreeland
wants to merge
8
commits into
chainguard-dev:main
Choose a base branch
from
justinvreeland:push-sozltsowwuyr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RFC: Source fetch from melange #2170
justinvreeland
wants to merge
8
commits into
chainguard-dev:main
from
justinvreeland:push-sozltsowwuyr
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
build this and then run something like:
|
sergiodj
reviewed
Oct 9, 2025
jonjohnsonjr
reviewed
Oct 9, 2025
3a4ae60 to
fcdbdaa
Compare
Contributor
Author
|
Contributor
Author
|
@sergiodj Take a look at the new updates. |
Contributor
Author
|
I feel like i could probably just edit the melange config and write it out somehow and not call yam but this is mostly just poc stuff. |
This subcommand pulls the source a build config. Currently it only supports git-checkout but in the future it should suppport more functionality. The purpose of this is to make interacting with upstream source and patches easier. I'd like a workflow like `melange source -o sources/ package.yaml` to setup a git tree with patches applied and another command that can do the revese. There's something similiar in source.go for license checks. That version runs the same shell script that the pipeline has. This command is meant for setting up an environment that can be used to develope against the upstream sources. I'm not interested shallow cloning or keeping a consistent commiter id or anything here. I'm realy just trying to make it easy to develop/debug packages using the upstream source.
fcdbdaa to
c01a3c1
Compare
Contributor
Author
of course it is. |
b6987c3 to
eb120ee
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want this to be for development not for building which is why i'm not doing what sources did and running the pipeline which should be fine shell code. I also want all of the history if i'm doing development.
IMO Ideally the source locations would be used in pipelines but not actually defined in it so that other pipelines could reference it and melange could make smart choices. The update section for example of one that already works around this.
I'd really like to make a world in the future where we can enforce that all patches are applied in a sensible predictable order independent of the melange tool. As far as I can tell right now the best way to do that is to apply them to the source an pop ALL of our patches off as a stack from format-patch.