git-checkout: Invoke git fetch with --unshallow
#2258
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
approved these changes
Dec 6, 2025
Melange currently barfs on specific cherry-pick situations like the one at wolfi-dev/os#74858 . I spent some time investigating this and found that this happens because the initial `git clone` to fetch a tag is done in shallow mode, and then subsequent `git fetch` commands will be constrained by the "shallowness" that was created. I was surprised to find @smoser's chainguard-dev#1473 which pretty much reached the same conclusion. My suggestion is that we should bite the bullet here and just invoke the `git fetch` that's run during `cherry-pick` using the `--unshallow` option. The downside is that this will pull in the entire repository history, which can be a lot in some cases. Signed-off-by: Sergio Durigan Junior <sergiodj@chainguard.dev>
sergiodj
force-pushed
the
git-checkout-unshallow
branch
from
e402cb8 to
607b429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Melange currently barfs on specific cherry-pick situations like the one at wolfi-dev/os#74858 . I spent some time investigating this and found that this happens because the initial
git cloneto fetch a tag is done in shallow mode, and then subsequentgit fetchcommands will be constrained by the "shallowness" that was created. I was surprised to find @smoser's #1473 which pretty much reached the same conclusion.My suggestion is that we should bite the bullet here and just invoke the
git fetchthat's run duringcherry-pickusing the--unshallowoption. The downside is that this will pull in the entire repository history, which can be a lot in some cases.Closes: #1473