Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Melange
Pipeline
type shouldn't rely on a concrete type like*logrus.Entry
, because this requires users to have a concrete type ornil
, andnil
causes panics in the logger implementation.Using an abstraction instead allows consumers to use other loggers (including a
nopLogger
) when logging isn't needed or wanted.This caused a panic in
wolfictl
, and a forthcoming wolfictl PR will take advantage of this change (with tests!).