Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignore-regex-patterns update config to indicate you want to ign… #406

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

rawlingsj
Copy link
Member

…ore string patterns that match an upstream version

…ore string patterns that match an upstream version

Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
@rawlingsj rawlingsj requested a review from a team as a code owner April 28, 2023 09:40
@rawlingsj rawlingsj requested review from jonjohnsonjr and removed request for a team April 28, 2023 09:40
@rawlingsj
Copy link
Member Author

Why use a slice of regex patterns rather than a single string, I hear you ask... maintainability. Regex are not a great UX and modifying existing regex is daunting when there's no tests. Using a regex in YAML doesn't have tests so it is easier for maintainers and contributors to add a new pattern if and when needed.

@rawlingsj rawlingsj merged commit b89afc0 into chainguard-dev:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants