add extra logging when runner fails to TestUsability #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a recent change made bubblewrap the default when running melange build natively on mac, as a result builds fail to start... ``` 2023/05/13 11:29:15 error during command execution: unable to run container ``` This change adds a warning when the check fails and offers the user help of how to fix. For example now I need to run `melange build --runner docker` Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
imjasonh
approved these changes
May 13, 2023
|
hmm, we should fix it. bubblewrap shouldn't ever be the default on mac |
|
You're right it shouldn't. I'll fix that. I originally had an auto detect in there, removed it for some reason lost in the mists of time. Will get it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a recent change made bubblewrap the default when running melange build natively on mac, as a result builds fail to start...
This change adds a warning when the check fails and offers the user help of how to fix. For example now I need to run
melange build --runner docker