Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop breaking github action. #546

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Stop breaking github action. #546

merged 2 commits into from
Jul 18, 2023

Conversation

mesaglio
Copy link
Contributor

@mesaglio mesaglio commented Jul 13, 2023 •
edited
Loading

To stop other pr gh-action brakes, we can comment the test while I work on the fix in this days.

@mesaglio
Comment python test.
6e13401 
Signed-off-by: Juan Mesaglio <juan.mesaglio@gmail.com>
@mesaglio mesaglio requested a review from a team as a code owner July 13, 2023 01:39
@mesaglio mesaglio requested review from joshrwolf and removed request for a team July 13, 2023 01:39
@mesaglio
Copy link
Contributor Author

mesaglio commented Jul 13, 2023 •
edited
Loading

@rawlingsj @deitch
I am trying to change that in the tests, make httptestserver request, avoiding going to pypi repository.

@mesaglio
Finally fix python convert tests.
57149ad 
Signed-off-by: Juan Mesaglio <juan.mesaglio@gmail.com>
@mesaglio mesaglio force-pushed the fix/comment_python_convert_test branch from 5def52b to 57149ad Compare July 13, 2023 03:00
@mesaglio
Copy link
Contributor Author

mesaglio commented Jul 13, 2023 •
edited
Loading

This fix the issue in python convert test.

This problem was because the last version generated by the pypi jsonschema package has a library that when created the pr did not have and it failed to validate the number of packages it should generate. What I did was, in tests consume the httptest instead of pypi. This could have happened with the botocore library too.

@kaniini kaniini enabled auto-merge July 18, 2023 00:49
@kaniini kaniini merged commit 567cc0f into chainguard-dev:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaniini kaniini kaniini approved these changes

@joshrwolf joshrwolf Awaiting requested review from joshrwolf joshrwolf was automatically assigned from chainguard-dev/images-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesaglio @kaniini