Default remove builder #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrwolf
force-pushed
the
default-remove-builder
branch
3 times, most recently
from
949e136 to
1f0f09e
Compare
imjasonh
previously approved these changes
Jul 17, 2023
Signed-off-by: Josh Wolf <josh@wolfs.io>
joshrwolf
force-pushed
the
default-remove-builder
branch
from
1f0f09e to
e16fb77
Compare
kaniini
reviewed
Jul 17, 2023
| @@ -1645,6 +1654,13 @@ func (b *Build) BuildPackage(ctx context.Context) error { | |||
| if err := b.Runner.StartPod(ctx, cfg); err != nil { | |||
| return fmt.Errorf("unable to start pod: %w", err) | |||
| } | |||
| if !b.DebugRunner { | |||
There was a problem hiding this comment.
Suggested change
| if !b.DebugRunner { | |
| if !b.DebugRunner && !b.IsBuildLess() { |
There was a problem hiding this comment.
this conditional is already inside of the outer:
if !b.IsBuildLess() {
kaniini
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default for runners that create a persisting build environment (everything except
bwrap) to always destroy the build environment when the build succeeds/fails.This means runners like
docker/kubernetesdon't leave dangling resources around on failures unless the user opts in (--debug-runner).I originally coupled this to the existing
--debugflag, but then changed my mind and used--debug-runner. I'm not married to the semantics so please suggest otherwise!