skip the cache mount for kubernetes runner builds #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Wolf <josh@wolfs.io>
mattmoor
reviewed
Jul 22, 2023
Signed-off-by: Josh Wolf <josh@wolfs.io>
joshrwolf
force-pushed
the
k8s-runner-cache-mount
branch
from
9cad4cb to
aaf439c
Compare
mattmoor
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the melange cache mounts are primarily designed for bind-mounted runners, which k8s is not. in remote execution environments, it's usually just faster to redownload things than to push/pull them in.
using the cache mount for k8s runner ends up just creating more things that need to be transferred over the network via kontext -> OCI registry, and can lead to pretty silly processing if you're not careful.
this also prevents @mattmoor from destroying his poor computer/network