Make sure we log errors. #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts fdf0cbf which avoided double-printing (some?) errors, but the net effect of this is that some errors are never printed. Performing world builds, I see half a dozen failures(?) where the logs end without actually printing anything actionable: ``` ... ℹ️ x86_64 | populating cache from ℹ️ x86_64 | populating workspace /home/user/tmp/melange-workspace-2016802746 from ./jaeger-agent/ ℹ️ x86_64 | --cache-dir ./melange-cache/ not a dir; skipping ℹ️ x86_64 | ImgRef = gcr.io/mattmoor-chainguard/wolfi-os-builds@sha256:98b659b74c47411018b386fdb4fbb8aa0140eb5b11c19b1473c99c96da2524ef ℹ️ x86_64 | creating mount 'mount-0' from /home/user/tmp/melange-workspace-2016802746 at /home/build ℹ️ x86_64 | workspace dir: /home/user/tmp/melange-workspace-2016802746 ℹ️ x86_64 | guest dir: /home/user/tmp/melange-guest-1521123713 ``` IMO printing some things twice is strictly worse than not printing some errors at all, and this is the surest way to ensure all errors are printed. Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
kaniini
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts fdf0cbf which avoided double-printing (some?) errors, but the net effect of this is that some errors are never printed.
Performing world builds, I see half a dozen failures(?) where the logs end without actually printing anything actionable:
IMO printing some things twice is strictly worse than not printing some errors at all, and this is the surest way to ensure all errors are printed.
cc @luhring who made the original change