-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc and lint revisions #598
Conversation
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
…RLHTTPClient Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
It does not actually seem to be present in this PR. |
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Please run |
I'm not seeing any |
Yeap, I saw that failure and fixed it here 1872fa5 |
Ok, looks fine. I have decided to just set the auto-merge to do a squash, so don't worry about the commits. |
I also added
.pre-commit-config.yaml
to the repo. To use it:pip install pre-commit
pre-commit install
This will create .git/hooks/pre-commit and following that, these tests will run every time you invoke
git commit
:For now, I commented the
go-imports
,go-vet
,go-lint
andgo-critic
as they still have findings that should be looked at but I recommend enabling these once that's done.To run all checks, uncomment them in
.pre-commit-config.yaml
, invokepre-commit install
and runpre-commit run --all-files
Attached is the full output of such a run.
melange-lint.log