Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc and lint revisions #598

Merged
merged 16 commits into from
Aug 10, 2023
Merged

doc and lint revisions #598

merged 16 commits into from
Aug 10, 2023

Conversation

jessp01
Copy link
Contributor

@jessp01 jessp01 commented Aug 10, 2023

  • Some typo corrections
  • Doc line above exported consts and functions
  • Implemented some golint suggestions

I also added .pre-commit-config.yaml to the repo. To use it:

This will create .git/hooks/pre-commit and following that, these tests will run every time you invoke git commit:

go fmt...................................................................Passed
go imports...............................................................Passed
go vet...................................................................Passed
go lint..................................................................Passed
go-critic................................................................Passed

For now, I commented the go-imports, go-vet, go-lint and go-critic as they still have findings that should be looked at but I recommend enabling these once that's done.

To run all checks, uncomment them in .pre-commit-config.yaml, invoke pre-commit install and run pre-commit run --all-files

Attached is the full output of such a run.
melange-lint.log

jessp01 added 15 commits August 10, 2023 01:33
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
…RLHTTPClient

Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
Signed-off-by: Jesse Portnoy <jesse@packman.io>
@jessp01 jessp01 requested a review from a team as a code owner August 10, 2023 01:02
@jessp01 jessp01 requested review from rawlingsj and removed request for a team August 10, 2023 01:02
kaniini
kaniini previously approved these changes Aug 10, 2023
@kaniini
Copy link
Contributor

kaniini commented Aug 10, 2023

I also added .pre-commit-config.yaml to the repo.

It does not actually seem to be present in this PR.

@kaniini kaniini removed the request for review from rawlingsj August 10, 2023 01:07
@kaniini kaniini self-assigned this Aug 10, 2023
pkg/cli/update_cache.go Outdated Show resolved Hide resolved
Signed-off-by: Jesse Portnoy <jesse@packman.io>
@kaniini
Copy link
Contributor

kaniini commented Aug 10, 2023

Please run go fmt ./... on the code. Also, please flatten the commits, grouping them by concern.

@jessp01
Copy link
Contributor Author

jessp01 commented Aug 10, 2023

I'm not seeing any gofmt warnings in any of my changed files (or any files in this repo for that matter). Which file are you referring to?

@kaniini kaniini enabled auto-merge (squash) August 10, 2023 01:24
@jessp01
Copy link
Contributor Author

jessp01 commented Aug 10, 2023

Yeap, I saw that failure and fixed it here 1872fa5

@kaniini
Copy link
Contributor

kaniini commented Aug 10, 2023

Ok, looks fine. I have decided to just set the auto-merge to do a squash, so don't worry about the commits.

@kaniini kaniini merged commit 1a34465 into chainguard-dev:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants