Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ${{targets.contextdir}} #622

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Add ${{targets.contextdir}} #622

merged 3 commits into from
Aug 21, 2023

Conversation

kaniini
Copy link
Contributor

@kaniini kaniini commented Aug 21, 2023

Adds ${{targets.contextdir}} variable expansion which maps to the current package output context directory. This is intended to be used as a destination target instead of ${{targets.destdir}} and ${{targets.subpkgdir}}, allowing pipelines to be more reusable in subpackages, without hacks like ${{inputs.subpackage}}.

…t dir

Previously, pipelines would have to have special logic to handle the
difference between ${{targets.destdir}} and ${{targets.subpkgdir}} based
on whether a pipeline was running a build pipeline or subpackage
pipeline.

We now introduce ${{targets.contextdir}} which can be used as a smarter
replacement for both variables in most cases.

Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
This allows for a package definition to refer to the target directory
of any package/subpackage defined in the recipe, e.g. for moving files
around.

Instead of using ${{targets.destdir}} as a source, users can instead
specify ${{targets.package.foo}}.

Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini kaniini requested a review from a team as a code owner August 21, 2023 17:19
@kaniini kaniini requested review from jdolitsky and removed request for a team August 21, 2023 17:19
@kaniini
Copy link
Contributor Author

kaniini commented Aug 21, 2023

Looks like guac will have to be fixed up once this lands.

@kaniini kaniini merged commit 074bfa2 into main Aug 21, 2023
@kaniini kaniini deleted the feature/targets-contextdir branch August 21, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants