log and continue when .pc file can't be loaded #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jason@chainguard.dev>
jonjohnsonjr
approved these changes
Sep 19, 2023
joshrwolf
reviewed
Sep 19, 2023
| @@ -614,7 +614,8 @@ func generatePkgConfigDeps(pc *PackageBuild, generated *config.Dependencies) err | |||
|
|
|||
| pkg, err := pkgconfig.Load(filepath.Join(pc.WorkspaceSubdir(), path)) | |||
| if err != nil { | |||
| return err | |||
| pc.Logger.Printf("WARNING: Unable to load .pc file (%s) using pkgconfig: %v", path, err) | |||
There was a problem hiding this comment.
Suggested change
| pc.Logger.Printf("WARNING: Unable to load .pc file (%s) using pkgconfig: %v", path, err) | |
| pc.Logger.Warnf("Unable to load .pc file (%s) using pkgconfig: %v", path, err) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also only match files ending in
.pcWe weren't able to build some packages that contained paths like
usr/share/mime/application/vnd.tcpdump.pcap.xmlbecause the post-build pkgconfig pass tried to parse that file and failed.