Add post-file walk linting and empty package linting #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elizafox
force-pushed
the
binarylinter
branch
from
5913c2c to
3104cde
Compare
|
Hmm, some packages are failing. I'll try to investigate soon. |
Signed-off-by: Elizabeth Myers <elizabeth.myers@chainguard.dev>
Signed-off-by: Elizabeth Myers <elizabeth.myers@chainguard.dev>
Elizafox
force-pushed
the
binarylinter
branch
from
3379d8a to
49688bf
Compare
|
So I've discovered in my travels that gdk-pixbuf had an empty metapackage that wasn't necessary, and exa had an empty docs package. So these weren't spurious failures at all. The linter did what it was supposed to do. This linter is likely to show a lot of empty packages. I don't know if I should make this an optional lint for the moment, or rip the band-aid off now. |
kaniini
previously requested changes
Sep 20, 2023
Signed-off-by: Elizabeth Myers <elizabeth.myers@chainguard.dev>
kaniini
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks for empty packages and also adds a facility to allow for post-walk lints that can walk the tree or do whatever.