Track vendored deps for .PKGINFO #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we discover a vendored dependency (outside of libdirs), we will use that to self-satisfy any generated runtime dependencies. Notably, we will not use these vendored dependencies to satisfy any explicitly configured runtime dependencies so that we have an escape hatch for overriding the SCA. This also adds `# vendored = ...` comments to .PKGINFO so that we can debug cases that would otherwise appear as a missing runtime dependency. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
|
I am pretty comfortable with this change. I ran against wolfi HEAD last night and produced https://gist.github.com/jonjohnsonjr/4cb59e0503cd16d064184d0b82c20050 There are a handful of things that seem off, filed wolfi-dev/os#6199 for those. Packages that will have vendored things post bump:
It seems like only the dotnet packages really make sense here and the others will need to be fixed, but the part that removes these libraries from being provided has already landed in melange. This change only removes some of these libraries from being added as |
imjasonh
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we discover a vendored dependency (outside of libdirs), we will use that to self-satisfy any generated runtime dependencies. Notably, we will not use these vendored dependencies to satisfy any explicitly configured runtime dependencies so that we have an escape hatch for overriding the SCA.
This also adds
# vendored = ...comments to .PKGINFO so that we can debug cases that would otherwise appear as a missing runtime dependency.(Draft for now because I would like to do a dry run of this new logic against existing packages to see if there are any unexpected diffs.)