Enable linters to warn (via callback) instead of just failing. #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
force-pushed
the
support-linter-warnings
branch
2 times, most recently
from
319d760
to
1ece998
Compare
mattmoor
commented
Oct 4, 2023
This also adds the flag `--fail-on-lint-warning` to force all active linters to error instead of simply printing their message. Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
mattmoor
force-pushed
the
support-linter-warnings
branch
from
129a4c5
to
7280283
Compare
kaniini
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds the flag
--fail-on-lint-warningto force all active linters to error instead of simply printing their message.Melange Pull Request Template
Functional Changes
Notes:
All linters are now warn-only.
SCA Changes
Notes:
This doesn't touch APK generation at all.
Linter
Notes:
All checks are warnings.