Filter out noise from opening non-ELF files with the stripped linter #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other errors are signs things are quite amiss and should be warned, but a bad magic number value can occur for harmless reasons like scripts. So there's no point in reporting these errors. Signed-off-by: Elizabeth Myers <elizabeth.myers@chainguard.dev>
Elizafox
force-pushed
the
filter-elf-noise
branch
from
be967d1 to
d05fa1b
Compare
To make this work would require effort to make the stripped linter understand archives and .o files. Don't bother right now. Signed-off-by: Elizabeth Myers <elizabeth.myers@chainguard.dev>
Elizafox
force-pushed
the
filter-elf-noise
branch
2 times, most recently
from
3c62a91 to
b0ea2de
Compare
Signed-off-by: Elizabeth Myers <elizabeth.myers@chainguard.dev>
Elizafox
force-pushed
the
filter-elf-noise
branch
from
b0ea2de to
0b25a6b
Compare
|
Closing for now as @jonjohnsonjr has mentioned the intention to refactor a bunch of stuff and this will need to be rewritten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other errors are signs things are quite amiss and should be warned, but a bad magic number value can occur for harmless reasons like opening a script or some improperly set executable bit. So there's no point in reporting these errors.
No functional linter changes beyond this cosmetic change during build.