Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GithubReleaseMonitor: add tagprefix and tagcontains to be used in git… #834

Merged
merged 3 commits into from
Nov 8, 2023
Merged

GithubReleaseMonitor: add tagprefix and tagcontains to be used in git… #834

merged 3 commits into from
Nov 8, 2023

Conversation

ajayk
Copy link
Contributor

@ajayk ajayk commented Nov 8, 2023

GithubReleaseMonitor: add tagprefix and tagcontains to be used in github tags filtering

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

@ajayk ajayk force-pushed the tags branch 3 times, most recently from df5f7ec to 37ca08e Compare November 8, 2023 00:33
pdeslaur
pdeslaur reviewed Nov 8, 2023
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
@ajayk ajayk requested a review from pdeslaur November 8, 2023 05:02
jonjohnsonjr
jonjohnsonjr reviewed Nov 8, 2023
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
jonjohnsonjr
jonjohnsonjr previously requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to add a comment to remove TagFilter (or at that it's deprecated).

pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@ajayk
GithubReleaseMonitor: add tagprefix and tagcontains to be used in git…
f91e705 
…hub tags filtering

Signed-off-by: ajayk <ajaykemparaj@gmail.com>
@ajayk
Copy link
Contributor Author

ajayk commented Nov 8, 2023

May want to add a comment to remove TagFilter (or at that it's deprecated).

done

@ajayk ajayk requested a review from jonjohnsonjr November 8, 2023 21:44
ajayk and others added 2 commits November 8, 2023 15:10
@ajayk @jonjohnsonjr
Update pkg/config/config.go
eab6cc0 
Co-authored-by: Jon Johnson <jonjohnsonjr@gmail.com>
@ajayk @jonjohnsonjr
Update pkg/config/config.go
751522b 
Co-authored-by: Jon Johnson <jonjohnsonjr@gmail.com>
@ajayk ajayk enabled auto-merge November 8, 2023 23:11
@ajayk ajayk merged commit ecd6ea9 into chainguard-dev:main Nov 8, 2023
25 of 26 checks passed
@Porkepix Porkepix mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeslaur pdeslaur pdeslaur approved these changes

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajayk @pdeslaur @jonjohnsonjr