Don't include libexec directories in SCA includes #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our logic for matching libdirs just used a string prefix, but didn't include a "/" at the end of the allowlisted directories. This meant we matched things under "/usr/libexec", which we probably don't want. The only APKs that has "usr/libexec" files are these neon APKs. Since it's vendoring various versions of libpq, and we don't want other packages to depend on neon (it's huge) but the libpq things directly, we don't want to expose these as provides. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
imjasonh
approved these changes
Jan 24, 2024
|
This PR should probably be reverted. In general, binaries in libexec are not vendored copies of other packages, but instead just normal binaries that should be analyzed like any other. A better approach worth considering would be a configurable set of path prefixes to exempt from the SCA analyzers. Thus, in neon.yaml you might have something like: sca:
protected-paths:
- /usr/libexec/neon/* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logic for matching libdirs just used a string prefix, but didn't include a "/" at the end of the allowlisted directories. This meant we matched things under "/usr/libexec", which we probably don't want. The only APKs that has "usr/libexec" files are these neon APKs. Since it's vendoring various versions of libpq, and we don't want other packages to depend on neon (it's huge) but the libpq things directly, we don't want to expose these as provides.