Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip when executing on an unsupported arch #976

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Feb 3, 2024

If you melange build a package for one arch, it should not cause an error to melange test that package on a different arch -- it shouldn't even care that the package to test doesn't exist.

Tested with:

$ go run ./ build examples/one-arch.yaml
# succeeds
$ go run ./ test examples/one-arch.yaml  ./packages/x86_64/one-arch-0.0.1-r0.apk --arch=x86_64
# passes              
$ go run ./ test examples/one-arch.yaml  ./packages/x86_64/one-arch-0.0.1-r0.apk --arch=aarch64              
⚠️            | skipping test for one-arch on arm64
$ go run ./ test examples/one-arch.yaml  ./packages/armv7/one-arch-0.0.1-r0.apk --arch=aarch64
⚠️            | skipping test for one-arch on arm64

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh merged commit 7d00f14 into chainguard-dev:main Feb 3, 2024
32 checks passed
@vaikas
Copy link
Member

vaikas commented Feb 3, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants