Fix race condition in log monitoring #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason we were using os.Pipe instead of io.Pipe for an in-process pipe. I've switched those over to using io.Pipe so we can CloseWithError. Also, switched to using errgroup.Group instead of manual channel signaling. Now, when we hit an error, we actually log that error instead of the line just before that error. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
jonjohnsonjr
force-pushed
the
pipes-pipes-pipes
branch
from
a9a3ae6
to
855a27c
Compare
joshrwolf
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we were using os.Pipe instead of io.Pipe for an in-process pipe. I've switched those over to using io.Pipe so we can CloseWithError.
Also, switched to using errgroup.Group instead of manual channel signaling.
Now, when we hit an error, we actually log that error instead of the line just before that error.