Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Close() method to container runners #984

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Add Close() method to container runners #984

merged 1 commit into from
Feb 5, 2024

Commits on Feb 5, 2024

  1. Add Close() method to container runners 

    We were doing some needless RPCs to the docker daemon because we
reconstruct a new client every time.

Instead, construct a client once and close it in a Close() method. Plumb
Close() methods up through to melange build/test as well.

Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
    @jonjohnsonjr
    jonjohnsonjr committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    298b335 View commit details
    Browse the repository at this point in the history