Respond to cancelled context while streaming logs #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since StdCopy is a blocking call, even if ctx is cancelled, we won't actually clean up any containers. This isn't a complete solution, but it's really straightfoward to implement, so I'm starting here. This only works when logs are being actively streamed (so we are actually calling Read). If the container isn't very chatty, this isn't as effective. This is harmless to keep in, but we can also remove it when we have a better solution. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
jonjohnsonjr
force-pushed
the
ctxreader
branch
from
76483f3
to
e6101ae
Compare
imjasonh
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since StdCopy is a blocking call, even if ctx is cancelled, we won't actually clean up any containers. This ~fixes that.
This isn't a complete solution, but it's really straightfoward to implement, so I'm starting here. This only works when logs are being actively streamed (so we are actually calling Read). If the container isn't very chatty, this isn't as effective.
This is harmless to keep in, but we can also remove it when we have a better solution.