Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --die-with-parent to bwrap flags #997

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Add --die-with-parent to bwrap flags #997

merged 1 commit into from
Feb 7, 2024

Conversation

jonjohnsonjr
Copy link
Contributor

This prevents us from failing when background processes have not exited.

@jonjohnsonjr
Add --die-with-parent to bwrap flags
dfd9dff 
This prevents us from failing when background processes have not exited.

Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
@joshrwolf
Copy link
Contributor

any chance this is going to bite us? containers/bubblewrap#529

@jonjohnsonjr
Copy link
Contributor Author

We already set --unshare-pid, so I think we're good unless you mean something else in that thread?

@joshrwolf
Copy link
Contributor

We already set --unshare-pid, so I think we're good unless you mean something else in that thread?

duh, I missed it!

@jonjohnsonjr jonjohnsonjr merged commit 2c564fd into chainguard-dev:main Feb 7, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshrwolf joshrwolf joshrwolf approved these changes

@imjasonh imjasonh imjasonh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonjohnsonjr @joshrwolf @imjasonh