Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use clog instead of knative.dev/pkg/logging #104

Merged
merged 1 commit into from
Feb 1, 2024
Merged

use clog instead of knative.dev/pkg/logging #104

merged 1 commit into from
Feb 1, 2024

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Feb 1, 2024 •
edited
Loading

knative.dev/pkg/apis is still used by policy, but otherwise knative.dev/pkg is unused after this.

@imjasonh
use clog instead of knative.dev/pkg/logging
1446144 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh marked this pull request as ready for review February 1, 2024 20:00
@imjasonh imjasonh requested a review from cmdpdx February 1, 2024 20:00
cmdpdx
cmdpdx approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@cmdpdx cmdpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@imjasonh imjasonh merged commit d8f7d0e into chainguard-dev:main Feb 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmdpdx cmdpdx cmdpdx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjasonh @cmdpdx