Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export HTTP_AUTH to github env #17

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix: export HTTP_AUTH to github env #17

merged 3 commits into from
Nov 13, 2024

Conversation

89luca89
Copy link
Contributor

it's useful for some situations where we need auth for packages or whatnot

Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
@k4leung4
Copy link

it's useful for some situations where we need auth for packages or whatnot

can you make this configurable, as some user may not want to have it exported?

Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
@89luca89
Copy link
Contributor Author

it's useful for some situations where we need auth for packages or whatnot

can you make this configurable, as some user may not want to have it exported?

Done as requested 🫡

Copy link

@k4leung4 k4leung4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@89luca89
Copy link
Contributor Author

Thanks!

@89luca89 89luca89 merged commit 8d93dcb into main Nov 13, 2024
9 checks passed
@89luca89 89luca89 deleted the fix/export_http_auth branch November 13, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants