Add a NotBefore option, use it for back-off during retries.
#586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a `NotBefore` option to the workqueue (not exposed via the proto yet), which directs the implementations to delay when certain keys appear in the queue for processing. This same mechanism is now used to add a back-off when requeuing keys that carry a priority to keep failing high-priority tasks from starving low-priority tasks (h/t Nghia for thinking of this scenario). GCS conformance: ``` WORKQUEUE_GCS_TEST_BUCKET=mattmoor-testing-workqueue go test -timeout=10m -count=1 ./pkg/workqueue/gcs ok github.com/chainguard-dev/terraform-infra-common/pkg/workqueue/gcs 262.813s ``` Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
mattmoor
force-pushed
the
nbf-workqueue
branch
from
806375a to
3785b64
Compare
tcnghia
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
NotBeforeoption to the workqueue (not exposed via the proto yet), which directs the implementations to delay when certain keys appear in the queue for processing.This same mechanism is now used to add a back-off when requeuing keys that carry a priority to keep failing high-priority tasks from starving low-priority tasks (h/t Nghia for thinking of this scenario).