-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cert-manager and https cert automatic issuing #29
Conversation
a0fb092
to
4d07108
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT if we install certmanager using helm provider like it is done here?
https://github.com/chainstack/infrastructure/tree/master/tf-modules/helm/certmanager
I don't want to increase the complexity of the repository by nesting directories. Also the number of manual steps users need to go through is undesirable IMHO.
I understand that you don't want to duplicate certmanager installation in each tf module.
I decided not to add that to terraform (at least for now) cause:
I also don't like idea adding more nested structures, but I'm going to merge on helmfile in future, so I think it would be simplified in 3rd milestone. P.S. Also this helmfile is going to contain kube-dashboard and prometheus+grafana installation |
65ff230
to
a4e5cba
Compare
Add installation of cert-manager
/fix #11