Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cert-manager and https cert automatic issuing #29

Merged
merged 8 commits into from
Aug 2, 2021

Conversation

dm3ch
Copy link
Contributor

@dm3ch dm3ch commented Jul 26, 2021

Add installation of cert-manager

/fix #11

@dm3ch dm3ch marked this pull request as draft July 26, 2021 14:18
@dm3ch dm3ch force-pushed the add-certmanager-and-monitoring branch from a0fb092 to 4d07108 Compare July 26, 2021 17:16
@dm3ch dm3ch marked this pull request as ready for review July 26, 2021 17:17
Copy link
Contributor

@zaslavskii zaslavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT if we install certmanager using helm provider like it is done here?
https://github.com/chainstack/infrastructure/tree/master/tf-modules/helm/certmanager

I don't want to increase the complexity of the repository by nesting directories. Also the number of manual steps users need to go through is undesirable IMHO.

I understand that you don't want to duplicate certmanager installation in each tf module.

.pre-commit-config.yaml Show resolved Hide resolved
@dm3ch
Copy link
Contributor Author

dm3ch commented Jul 27, 2021

WDYT if we install certmanager using helm provider like it is done here?
https://github.com/chainstack/infrastructure/tree/master/tf-modules/helm/certmanager

I don't want to increase the complexity of the repository by nesting directories. Also the number of manual steps users need to go through is undesirable IMHO.

I understand that you don't want to duplicate certmanager installation in each tf module.

I decided not to add that to terraform (at least for now) cause:

  1. It could be useful for bare-metal clusters (which are not covered by our terraform)
  2. It doesn't depends on any terraform resource outputs.

I also don't like idea adding more nested structures, but I'm going to merge on helmfile in future, so I think it would be simplified in 3rd milestone.

P.S. Also this helmfile is going to contain kube-dashboard and prometheus+grafana installation

@dm3ch dm3ch force-pushed the add-certmanager-and-monitoring branch from 65ff230 to a4e5cba Compare July 27, 2021 15:54
@dm3ch dm3ch requested a review from zaslavskii July 27, 2021 15:54
@zaslavskii zaslavskii merged commit aa56255 into main Aug 2, 2021
@zaslavskii zaslavskii deleted the add-certmanager-and-monitoring branch August 2, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding cert-manager support to graphprotocol-indexer-service
2 participants