Add learner nodes and hostname support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
easeev
commented
Dec 23, 2019
easeev
commented
- Add learner nodes support Quorum raft upgrade v3.3.13 Consensys/quorum#887
- Replace IP with hostname DNS support for static nodes and discovery Consensys/quorum#885
cthtuf
approved these changes
Dec 23, 2019
zaslavskii
requested changes
Dec 23, 2019
web3quorum/utils.py
Outdated
| @@ -11,9 +11,9 @@ def enode_to_raft_id(w3, enode: str) -> int: | |||
| return int(node.get('raftId')) | |||
|
|
|||
|
|
|||
| def ip_to_raft_id(w3, ip: str) -> int: | |||
| """Resolves IP into raft Id.""" | |||
| def ip_to_raft_id(w3, hostname: str) -> int: | |||
There was a problem hiding this comment.
probably you wanted to rename this accroding to https://github.com/chainstack/web3quorum/pull/1/files#diff-9767a019c97052bd346eb4c8728e7022R22
There was a problem hiding this comment.
strange, it seems like this function is used only in tests. So, I suppose, we can delete them both (test and function)
There was a problem hiding this comment.
Good catch, thanks!
It is used in https://github.com/chainstack/orchestrator/blob/master/server/networks/backends/quorum.py#L12
zaslavskii
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.