Feature UTXO handler #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azuchi
reviewed
Jul 7, 2020
| def header(data) | ||
| end | ||
|
|
||
| def merkleblock(data) |
There was a problem hiding this comment.
There doesn't seem to be any implementation, is this one left empty?
There was a problem hiding this comment.
I add implementation for merkleblock and header message.
When merkleblock is called, spv nodes will store the tx position data into the leveldb.
There was a problem hiding this comment.
I think the correctness of the merkleblock needs to be checked by restoring the markle tree.
* Delete key prefix 'h', 'b' because it is not used now.
azuchi
requested changes
Jul 27, 2020
| def header(data) | ||
| end | ||
|
|
||
| def merkleblock(data) |
There was a problem hiding this comment.
I think the correctness of the merkleblock needs to be checked by restoring the markle tree.
| # - Delete from utxo_db for spent output. | ||
| def tx(data) | ||
| tx = data.tx | ||
| tx.outputs.each_with_index do |output, index| |
There was a problem hiding this comment.
Don't you need to check if it is a Tx that exists in the merkleblock that you received earlier?
Co-authored-by: shigeyuki azuchi <azuchi@chaintope.com>
Co-authored-by: shigeyuki azuchi <azuchi@chaintope.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds UTXO handler to save UTXOs and delete UTXOs from the database.
As described in README.md, SPV node start to collect UTXOs associated with wallet when utxo handler is initialized.
Note that
merkleblockmessage in order to save the position of tx in the block but this PR does not contain it.Block height of UTXO is useful when we need to know UTXO is confirmed deeply (e.g. 6 confirmation) or not.
filteraddmessage when adding the keypair in the wallet usingBitcoin::Wallet::Base#generate_new_addressor other API.