Support to change xfield in a block #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naviabheeman
force-pushed
the
163_federationChangeToml
branch
4 times, most recently
from
e522d66 to
9709ca8
Compare
Every round, the master node checks the federations file to add xfield and member nodes verify their federations file signature and block xfield before signing the block Add tests to verify max block size and aggregated pubkey changes with signatures
…ubkeys and max_block_sizes rename unused variables with '_' prefix
…r schema. Update federation documentation
Naviabheeman
force-pushed
the
163_federationChangeToml
branch
from
a6e340e to
6fffc23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support to set the xfield in a block header when the change is approved by the federation. We read the federation change from
federations.toml. Aggregate-pubkey, threshold, node-vss, signature are optional and are needed when aggregated pubkey changes. max block size and signature are needed when max block size changes in the federation.SerFederationis converted toFederationwhere xfield is used. This is to unify the code processing aggregated-pub key and max-block-size. All federations are loaded and signature verified when a node starts. The first federation which defines the aggregated-pub key in the genesis block does not need a signature. Node would fail to start if there is an invalid entry in the toml.When a new round starts on master node, it gets the new xfield value from federation list based on block heigh. To add the xfield in the new block
getnewblockwithxfieldis used. it adds a string parameter "xfield_type:xfield_value" in the format that Tapyrus-core expects.When a candidate block is received for signature, the node checks that the xfield in the block is either empty or matches the xfield change in its
federations.toml. xfield signature is verified once again. Only valid blocks are signed.For federation aggregated pub key change, a description of the new federation i.e. threshold, node-vss and aggregated-pubkey are required in addition to a valid signature.
All nodes identify the results of a federation change attempt from
getblockchaininforpc output. All nodes create a log entry for each federation change attempt identified from the bock height infederations.tomlandgetblockchaininfooutput.