Workflow improvements (#251) #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* workflow: Add all-targets flag to clippy. * workflow: Add the new build_and_test workflow. * workflow: Remove all features and move services. * workflow: Remove old basic workflow. * workflow: Add cache warm ups for build and test. * workflow: Add all features flag to build and test. * workflow: Lower healt-retries to 5.
ekrembal
added a commit
that referenced
this pull request
Aug 29, 2024
* Set rpc endpoints and impl operator new deposit * Impl verifier new_deposit * Impl operator_kickoffs_generated * impl more verifier functions * Merge MuSig2 functions into ekrem/new-architecture (#206) * Add some musig2 functionalities * Some changes in general and in MuSig2 * Change musig2 functions * Add one small test * Added three more simple tests * Add test with dummy_tx key_spend * Add test with dummy_tx script_spend * Add rpc tests for key_spend and script_spend * Add wrappers for aggregate_nonces and aggregate_partial_signatures, formatting * Cargo fmt * Small change for config file * Some refactor * (WIP) Change XOnlyPublicKeys to PublicKeys in config files * Fix errors from pk-xonlypk change * More refactor * Remove code duplication * More refactor * Commentation + more refactor * Trying something * Removed Cargo.lock + add to .gitignore * Create XOnlyPublicKeys from PublicKeys using an extension trait (#216) Reduces code duplication and isolates the reponsibility to a dedicated function * Finalize new architecture for deposit except db operations (#211) * WIP * Fix some errors * WIP * Merge ozan/new-architecture-improvments into ekrem/new-architecture-improvments (#218) * WIP Impl. new endpoints * WIP Impl. new endpoints * nits * Implement move txs partial sig * WIP db nonce * Use UTXO instead of PsbtOutpoint * remove redundant db funcs --------- Co-authored-by: ozankaymak <92448699+ozankaymak@users.noreply.github.com> * Update DB for New Architecture (#222) * Change the db file for the new architecture * Change some UTXOs to OutPoints, add some checks * WIP Fix inconsistencies * WIP Impl database wrappers * Update schema * Fix some db * WIP * nits * Fix error for a wrapper, add some example db trait impl. and db func. * nits * WIP Impl. database functions --------- Co-authored-by: Ekrem BAL <mail.ekrembal@gmail.com> * Merge DB changes to ekrem/new-architecture (#227) * Update config files and impl. some db tests * WIP Fix checks and tests * (WIP) Add test for nonce table, fix small errors * (WIP) Add more tests for nonces table * (WIP) Add tests for get_pub_nonce * (WIP) Add test for deposit_utxo * Change operator new_deposit with new schema * WIP * DecodeRow inside the function * Current tests work * WIP * Fix Json issue with UTXODB * Clean wrapper.rs and formatting * Add tests for deposit_kickoff_generator_txs table * Apply review --------- Co-authored-by: Ekrem BAL <mail.ekrembal@gmail.com> * Remove code duplication (#228) * Merge withdrawal into ekrem/new-architecture (#234) * WIP * nits * Add sig check for withdrawal (#229) * Add sig check for withdrawal * Use tx.verify --------- Co-authored-by: Ekrem BAL <mail.ekrembal@gmail.com> * Impl operator paying withdrawal * Merge ozan/withdrawal-endpoint-test into ekrem-new-architecture (#230) * wip * WIP: created operators and verifiers * Add steps for the flow * Add withdrawal endpoint test,organize configs * Flaky but ok * Fix flakiness * Remove unnecessary serialization --------- Co-authored-by: lemonpartee <lemonpartey@proton.me> Co-authored-by: Ekrem BAL <mail.ekrembal@gmail.com> * Merge ozan/kickoff-root-operations into withdrawal (#231) * WIP Implement endpoints with db operations and tests * wip * WIP * WIP * Implement changes * Apply review changes * Refactor the binaries * Rename, refactor --------- Co-authored-by: Ekrem BAL <mail.ekrembal@gmail.com> --------- Co-authored-by: Ekrem BAL <mail.ekrembal@gmail.com> Co-authored-by: lemonpartee <lemonpartey@proton.me> * Implement sig_agg helpers (#237) Co-authored-by: ozankaymak <ozan.kaymak@boun.edu.tr> * Deposit test (#232) * wip * WIP: created operators and verifiers * Add steps for the flow * wip * Test e2e deposit flow * Undo unrelated changes * Fix agg nonces and use same deposit * Adjust test flow after rebase to withdrawal * Use create verifiers and operators func * Works until set_operator_funding_utxo_rpc * Fix create operators and verifiers * Fix sig aggregation * nits * WIP * WIP MuSig2VerifyError(BadSignature) * Debug * Fix error * Send move_tx + refactor --------- Co-authored-by: Ekrem BAL <mail.ekrembal@gmail.com> Co-authored-by: ozankaymak <ozan.kaymak@boun.edu.tr> * Apply review + refactor (#243) * Remove unused dependencies (#238) * Remove unused utils (#239) * Add docker compose with database (#245) * Introduce dockerized PostgresSQL database compatible with integration tests * refactor compose * Full withdrawal flow (#253) * Save operator take and slash or take sigs * Operator can find kickoff utxo * Operator can send kickoff tx onchain * WIP verifiers and operators should use same db missing * Fix bugs * WIP Boths sigs verified but operator_take_tx fails * WIP MuSig2 fix * Fix withdrawal happy part test * nits * Fix musig test * Use key aggregator trait --------- Co-authored-by: ozankaymak <ozan.kaymak@boun.edu.tr> * get rid of basic workflow * Workflow improvements (#251) (#255) * workflow: Add all-targets flag to clippy. * workflow: Add the new build_and_test workflow. * workflow: Remove all features and move services. * workflow: Remove old basic workflow. * workflow: Add cache warm ups for build and test. * workflow: Add all features flag to build and test. * workflow: Lower healt-retries to 5. Co-authored-by: Ceyhun Şen <ceyhuusen@gmail.com> * workflow: remove all features. * Merge "clippy" into "ekrem/new-architecture" * Fix CI config toml * Change CI config + remove warnings * Apply clippy suggestions for all * nits * Fix duplication * Fix CI error * Apply more clippy suggestions (#256) * cargo: Update mock_rpc. * workflow: Re-add --all-features. * workflow: Upgrade 4 cores to 16 cores. * perf: Insert nonces in a single batch (#248) * Cargo upgrade * minimize op_return usage * fmt --------- Co-authored-by: ozankaymak <92448699+ozankaymak@users.noreply.github.com> Co-authored-by: lemonpartee <lemonpartey@proton.me> Co-authored-by: ozankaymak <ozan.kaymak@boun.edu.tr> Co-authored-by: Ceyhun Şen <ceyhuusen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow: Add all-targets flag to clippy.
workflow: Add the new build_and_test workflow.
workflow: Remove all features and move services.
workflow: Remove old basic workflow.
workflow: Add cache warm ups for build and test.
workflow: Add all features flag to build and test.
workflow: Lower healt-retries to 5.
Description
Describe what this pull request does, here.
Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you
added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface,
have the docs been updated?