Fix u128 jsonrpc serialization/deserialization issue #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
koushiro
requested review from
liuchengxu and
atenjin
and removed request for
liuchengxu
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
liuchengxu
reviewed
Sep 17, 2020
liuchengxu
approved these changes
Sep 17, 2020
koushiro
added a commit
that referenced
this pull request
Oct 23, 2020
Previously, the `Balance`, `Price` and `Weight` were serialized directly into u128 numbers in #238, but polkadot.js could not parse them successfully. Therefore, it is necessary to serialize `Balance`, `Price`, and `Weight` back to String. Unlike before, the serialization conversion of `Balance` and `Price` only occurs at the RPC layer and does not involve the types in the pallet (because the `Weight` is an alias of u128, so we use serde derive directly on the type to complete the serialization conversion). Signed-off-by: koushiro <koushiro.cqx@gmail.com>
koushiro
added a commit
that referenced
this pull request
Oct 23, 2020
Previously, the `Balance`, `Price` and `Weight` were serialized directly into u128 numbers in #238, but polkadot.js could not parse them successfully. Therefore, it is necessary to serialize `Balance`, `Price`, and `Weight` back to String. Unlike before, the serialization conversion of `Balance` and `Price` only occurs at the RPC layer and does not involve the types in the pallet (because the `Weight` is an alias of u128, so we use serde derive directly on the type to complete the serialization conversion). Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: koushiro koushiro.cqx@gmail.com
JSON serialization/deserialization of
i128/u128can only be supported when thearbitrary_precisionfeature enabled.But
arbitrary_precisionnumbers don't work withserde(tag = ..)andserde(flatten)syntax (serde-rs/json#505), as a result, the deserialization of structures injsonrpc-corewill be error.Fortunately, the crate
jsonrpc-coreprovides a workround(paritytech/jsonrpc#521).Although this workround will cause more extra serialization/deserialization work, but I think it's worth it.