Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schnorr scale #80

Open
wants to merge 77 commits into
base: master
Choose a base branch
from
Open

Schnorr scale #80

wants to merge 77 commits into from

Conversation

icodezjb
Copy link
Member

  1. support schnorr
  2. support scale-info

hacpy and others added 30 commits August 2, 2021 17:26
@hacpy
Simple implementation of schnorr
6a845bb 
 * Add tagged hash

 * Construct schnorr challenge

 * Generate nonce and nonce point

 * Sign the message

 * Implement XOnly for the x coordinate of the point

 * Add a simple test to make sure the program works
@hacpy
Follow clippy
89817b4 
 * Impl From instead of Into

 * Use assert!() to assert true or false
@hacpy
Remove redundant references
bb96a68
@hacpy
Fix clippy
db0fe60 
 * Remove redundant reference
@hacpy
Add verify func and Signature
b165763
@hacpy
Fix ci lint
98e994c
@hacpy
Test with the right example
b3182fc
@hacpy
Passed BIP340 test
b3f077f 
 * Add keypair

 * Pass verify test
@hacpy
Choose a less ambiguous method name
3417974
@hacpy
Add error handling
291cd72 
 * Remove unwrap

 * More error details

 * More notes
@hacpy
Add sign with null aux
6afe108
@hacpy
Easier to use sign and verify
020a214 
 * Impl privkey.sign()

 * Impl pubkey.verify()
@hacpy
Implement From<T> instead of from and to methods
9474095 
 * Add comments

 * More error alerts

 * Implement From<T> and TryFrom<T> whenever possible
@hacpy
Generate random key
3e2eb36 
Add feature getrandom

 * Gen random nonce

 * Test sign_with_random passed

 * Temporarily remove useless keypair
@hacpy
Add check in verify()
94e6911 
 * Check signature overflow

 * Check X on curve

 * Check X corresponds to having two y
@hacpy
Add simple and rough batch verification
19e6a9b
@hacpy
Signature aggregation
960a28b 
  Just a simple aggregation, not tested and not checked internally for possible errors.
@hacpy
Remove helper function
8bea0ae
@hacpy
Remove unavailable functions
8d77c67 
  Signatures without random numbers will directly expose the private key, and of course if the random numbers are reused they will also expose the private key.
@hacpy
Fix warnings
7df4d95
@hacpy
Clearer conversion of XOnly to PublicKey
b1d5064
@hacpy
Verify schnorr signatures only
eb53b28 
 * Remove schnorr module

 * Add XOnly implementation in pubkey

 * Add SchnorrSignature implementation to the signature
@hacpy
Externally available XOnly and schnorr signature
25e3106
@hacpy
Make sure the public key is an even y
412bed1
Delete alloc feature of hex
e109406
Resolve dependency conflicts
22fd819
@hacpy
Wrap address type
015b67a
Add Type
bdfdffe
@hacpy
Support witness
f43bc54
@hacpy
Judge witness network
d80ee89
hacpy and others added 29 commits November 5, 2021 18:45
@hacpy
Add mast
5939253
@hacpy
Disable arrayref default feature
fb69bac
@hacpy
Use remote musig2
616c841
Fix Cargo.toml
f324850
Enable pub of mast
d001a10
Add Public to Pulickey
cc54d22
Add network to string
b30edbd
Allow single node of pmt
f2387a6
Support parallel compute
63afa63
Fix Cargo.toml
6271987
Resolve rayon conflict
d42889f
@hacpy
Use criterion instead of nightly feature
4ef10cc
@hacpy
Fix clippy
6ad4264
@icodezjb
Support scale-info
257adb1
@icodezjb
Bump version to v0.3.0
b45c45e
@icodezjb
Update libsecp256k1 and hashbrown
875db56
@icodezjb
Revert "Bump version to v0.3.0"
eceb852 
This reverts commit b45c45e
@icodezjb
Add miss files
f778727
Fix control block
d8ceefc
Fix build address
7099a1d
@hacpy
Add schnorr sign with aux
7a978ea
Fix test
e0bf2df
@hacpy
Remove pubkey param in sign
3375d99
@hacpy
Merge branch 'support-schnorr-test' of https://github.com/chainx-org/…
ffdfd81 
…light-bitcoin into support-schnorr-test
@hacpy
Impl Into for SchnorrSignature
fde8663
Fix verify schnorr
1f329df
@icodezjb
Merge branch 'schnorr-scale' into scale-info
91cc771
@icodezjb
Merge pull request #79 from chainx-org/scale-info
02c51c7 
Scale info
@icodezjb
Run cargo test --release --all
4e5546e
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #80 (4e5546e) into master (c0db1bc) will increase coverage by 5.36%.
The diff coverage is 78.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   67.04%   72.41%   +5.36%     
==========================================
  Files          38       44       +6     
  Lines        3823     4915    +1092     
==========================================
+ Hits         2563     3559     +996     
- Misses       1260     1356      +96
Impacted Files Coverage Δ
chain/src/block.rs 51.85% <ø> (+3.57%) ⬆️
chain/src/block_header.rs 69.23% <0.00%> (+1.30%) ⬆️
chain/src/indexed_block.rs 45.28% <ø> (+7.78%) ⬆️
chain/src/indexed_header.rs 33.33% <ø> (+2.08%) ⬆️
chain/src/indexed_transaction.rs 31.25% <ø> (+1.83%) ⬆️
keys/src/error.rs 0.00% <0.00%> (ø)
keys/src/private.rs 86.88% <ø> (+1.40%) ⬆️
mast/src/error.rs 0.00% <0.00%> (ø)
merkle/src/lib.rs 87.67% <0.00%> (+5.19%) ⬆️
primitives/src/bytes.rs 45.61% <ø> (+4.93%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0db1bc...4e5546e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icodezjb @hacpy