Remove unnecessary prototype creation

chakra-core · Jan 6, 2021 · 9c60dc4 · 9c60dc4
1 parent 9cd87d6
commit 9c60dc4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/lib/Runtime/Library/JavascriptAsyncGeneratorFunction.cpp b/lib/Runtime/Library/JavascriptAsyncGeneratorFunction.cpp
@@ -49,7 +49,8 @@ Var JavascriptAsyncGeneratorFunction::EntryAsyncGeneratorFunctionImplementation(
 
     auto* asyncGeneratorFn = VarTo<JavascriptAsyncGeneratorFunction>(function);
     auto* library = scriptContext->GetLibrary();
-    auto* prototype = library->CreateAsyncGeneratorConstructorPrototypeObject();
+    auto* prototype = VarTo<DynamicObject>(JavascriptOperators::GetPropertyNoCache(
+            function, Js::PropertyIds::prototype, scriptContext));
     auto* scriptFn = asyncGeneratorFn->GetGeneratorVirtualScriptFunction();
     auto* generator = library->CreateAsyncGenerator(args, scriptFn, prototype);
 
@@ -62,12 +63,5 @@ Var JavascriptAsyncGeneratorFunction::EntryAsyncGeneratorFunctionImplementation(
 
     generator->SetSuspendedStart();
 
-    // Set the prototype from constructor
-    JavascriptOperators::OrdinaryCreateFromConstructor(
-        function,
-        generator,
-        prototype,
-        scriptContext);
-
     return generator;
 }
diff --git a/lib/Runtime/Library/JavascriptGeneratorFunction.cpp b/lib/Runtime/Library/JavascriptGeneratorFunction.cpp
@@ -111,7 +111,8 @@ using namespace Js;
         auto* library = scriptContext->GetLibrary();
         auto* generatorFunction = VarTo<JavascriptGeneratorFunction>(function);
 
-        DynamicObject* prototype = library->CreateGeneratorConstructorPrototypeObject();
+        DynamicObject* prototype = VarTo<DynamicObject>(JavascriptOperators::GetPropertyNoCache(
+            function, Js::PropertyIds::prototype, scriptContext));
 
         JavascriptGenerator* generator = library->CreateGenerator(
             args,
@@ -127,13 +128,6 @@ using namespace Js;
 
         generator->SetSuspendedStart();
 
-        // Set the prototype from constructor
-        JavascriptOperators::OrdinaryCreateFromConstructor(
-            function,
-            generator,
-            prototype,
-            scriptContext);
-
         return generator;
     }