Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Simd.js code from ChakraCore - Part 2 (Remove) #3274

Closed
agarwal-sandeep opened this issue Jun 30, 2017 · 0 comments
Closed

Remove Simd.js code from ChakraCore - Part 2 (Remove) #3274

agarwal-sandeep opened this issue Jun 30, 2017 · 0 comments
Assignees
@Cellule
Labels
Codebase Quality Task
Milestone
WebAssembly-Next

Comments

@agarwal-sandeep
Copy link
Collaborator

Part 1 (#3273) of this change is to ifdef the code to not build. Once we figure out what can be reused for WASM simd we should remove rest of the code
@agarwal-sandeep agarwal-sandeep added this to the WebAssembly-Next milestone Jun 30, 2017
This was referenced Jul 6, 2017
Closed
Merged
@dilijev dilijev added the Task label Jul 7, 2017
chakrabot pushed a commit that referenced this issue Jul 12, 2017
@agarwal-sandeep
[MERGE #3296 @agarwal-sandeep] Remove Simd.js code from ChakraCore - …
6de0662 
…Part 1 (ifdef out)

Merge pull request #3296 from agarwal-sandeep:disablesimdjs

Put SIMDjs code in library, language and backend under #ifdef ENABLE_SIMDJS
undef ENABLE_SIMDJS
Some portion of SIMD code (IRType, OpCodesSimd, AsmJsBuiltInNames etc.) is used in WASM simd so it is left as it is. This will be take care of under #3274
Haven't ifdef'd TypeIds_SIMD* as that will make the TypeIds enum messy. During final cleanup we can clean this.

This reduce Chakra.dll x64 release binary size by 0.52 MB and ChakraCore x64 release binary size by 0.43 MB
chakrabot pushed a commit that referenced this issue Jul 12, 2017
@agarwal-sandeep
[1.6>1.7] [MERGE #3296 @agarwal-sandeep] Remove Simd.js code from Cha…
61480a5 
…kraCore - Part 1 (ifdef out)

Merge pull request #3296 from agarwal-sandeep:disablesimdjs

Put SIMDjs code in library, language and backend under #ifdef ENABLE_SIMDJS
undef ENABLE_SIMDJS
Some portion of SIMD code (IRType, OpCodesSimd, AsmJsBuiltInNames etc.) is used in WASM simd so it is left as it is. This will be take care of under #3274
Haven't ifdef'd TypeIds_SIMD* as that will make the TypeIds enum messy. During final cleanup we can clean this.

This reduce Chakra.dll x64 release binary size by 0.52 MB and ChakraCore x64 release binary size by 0.43 MB
chakrabot pushed a commit that referenced this issue Jul 12, 2017
@agarwal-sandeep
[1.7>master] [1.6>1.7] [MERGE #3296 @agarwal-sandeep] Remove Simd.js …
f4e2741 
…code from ChakraCore - Part 1 (ifdef out)

Merge pull request #3296 from agarwal-sandeep:disablesimdjs

Put SIMDjs code in library, language and backend under #ifdef ENABLE_SIMDJS
undef ENABLE_SIMDJS
Some portion of SIMD code (IRType, OpCodesSimd, AsmJsBuiltInNames etc.) is used in WASM simd so it is left as it is. This will be take care of under #3274
Haven't ifdef'd TypeIds_SIMD* as that will make the TypeIds enum messy. During final cleanup we can clean this.

This reduce Chakra.dll x64 release binary size by 0.52 MB and ChakraCore x64 release binary size by 0.43 MB
@Cellule Cellule mentioned this issue Aug 16, 2017
Closed
@Cellule Cellule mentioned this issue Jan 12, 2018
Merged
chakrabot pushed a commit that referenced this issue Feb 21, 2018
@Cellule
[MERGE #4541 @Cellule] Remove Simd.Js Code
e956d46 
Merge pull request #4541 from Cellule:remove_simdjs

Closes #3274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cellule Cellule

Labels
Codebase Quality Task
Projects
None yet
Milestone
WebAssembly-Next
Development

No branches or pull requests
4 participants
@dilijev @Cellule @agarwal-sandeep @curtisman