Repeated calls to class setter triggers assertion

[suwc]

class B {
    set x(v) { print("B.prototype.set x"); this._x = v; }
    get x() { print("B.prototype.get x"); return this._x; }
}

class A extends B {
    set x(v) { print("A.prototype.set x"); super.x = v + 100; }
    get x() { print("A.prototype.get x"); return super.x; }
}

var a = new A();
a.x = 100;
print(a.x);

var a1 = new A();
a1.x = 100;
print(a1.x);

Expected:

A.prototype.set x
B.prototype.set x
A.prototype.get x
B.prototype.get x
200
A.prototype.set x
B.prototype.set x
A.prototype.get x
B.prototype.get x
200

Actual

A.prototype.set x
B.prototype.set x
A.prototype.get x
B.prototype.get x
200
A.prototype.set x
ASSERTION 15068: (lib\runtime\Language/InlineCache.inl, line 356) setterValue == nullptr || setterValue == function
 Failure: (setterValue == nullptr || setterValue == function)
FATAL ERROR: ch.exe failed due to exception code c0000420

[pleath]

Do you think this is related to the super.x caching issues we’ve been looking at recently? It seems likely.

…

-- Paul From: suwc [mailto:notifications@github.com] Sent: Monday, July 24, 2017 3:37 PM To: Microsoft/ChakraCore <ChakraCore@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [Microsoft/ChakraCore] Repeated call to class setter triggers assertion (#3423) class B { set x(v) { print("B.prototype.set x"); this._x = v; } get x() { print("B.prototype.get x"); return this._x; } } class A extends B { set x(v) { print("A.prototype.set x"); super.x = v + 100; } get x() { print("A.prototype.get x"); return super.x; } } var a = new A(); a.x = 100; print(a.x); var a1 = new A(); a1.x = 100; print(a1.x); Expected: A.prototype.set x B.prototype.set x A.prototype.get x B.prototype.get x 200 A.prototype.set x B.prototype.set x A.prototype.get x B.prototype.get x 200 Actual A.prototype.set x B.prototype.set x A.prototype.get x B.prototype.get x 200 A.prototype.set x ASSERTION 15068: (lib\runtime\Language/InlineCache.inl, line 356) setterValue == nullptr || setterValue == function Failure: (setterValue == nullptr || setterValue == function) FATAL ERROR: ch.exe failed due to exception code c0000420 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FChakraCore%2Fissues%2F3423&data=02%7C01%7Cpleath%40microsoft.com%7Cc84bbebea9cb448644ac08d4d2e48402%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636365326293570734&sdata=2g%2FTEMg5Wt4FVE%2B%2B8rLgCAsntpl9X8x8G2cU0wWptMc%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPF8RETCBvb3ZbR2M1_Ccr33H7H4v7Ihks5sRRyRgaJpZM4Oh0_s&data=02%7C01%7Cpleath%40microsoft.com%7Cc84bbebea9cb448644ac08d4d2e48402%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636365326293570734&sdata=AKhsIZoAlIPiBHMlWrqPjgV4caL3dARnW%2FKtTBbuPkY%3D&reserved=0>.

[suwc]

@pleath this came up when I work on super.x caching. Will fix both in one PR