Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM: Reserved immediate #3450

Closed
Cellule opened this issue Jul 28, 2017 · 0 comments
Closed

WASM: Reserved immediate #3450

Cellule opened this issue Jul 28, 2017 · 0 comments
Assignees
@Cellule
Labels
Bug WebAssembly
Milestone
1.6

Comments

@Cellule
Copy link
Contributor

Cellule commented Jul 28, 2017

The reserved immediate to the current_memory and grow_memory operators is for future 🦄 use and must be 0 in the MVP.
The call_indirect operator takes a list of function arguments and as the last operand the index into the table. Its reserved immediate is for future 🦄 use and must be 0 in the MVP.

Currently we just ignore the reserved immediate, we need to validate that they're 0
@Cellule Cellule added this to the 1.6 milestone Jul 28, 2017
@Cellule Cellule self-assigned this Jul 28, 2017
@Cellule Cellule mentioned this issue Aug 2, 2017
Merged
Cellule added a commit to Cellule/ChakraCore that referenced this issue Aug 2, 2017
@Cellule
Make sure reserved value are 0
5160a42 
Fixes chakra-core#3450
Cellule added a commit to Cellule/ChakraCore that referenced this issue Aug 2, 2017
@Cellule
Make sure reserved value are 0
b3c3f4e 
Fixes chakra-core#3450
chakrabot pushed a commit that referenced this issue Aug 3, 2017
@Cellule
[MERGE #3469 @Cellule] WASM: reserved immediates
0d52124 
Merge pull request #3469 from Cellule:users/micfer/wasm/reserved

Make sure reserved value are 0
Fixes #3450
@Cellule Cellule closed this as completed Aug 3, 2017
chakrabot pushed a commit that referenced this issue Aug 3, 2017
@Cellule
[1.6>1.7] [MERGE #3469 @Cellule] WASM: reserved immediates
f95b7cb 
Merge pull request #3469 from Cellule:users/micfer/wasm/reserved

Make sure reserved value are 0
Fixes #3450
chakrabot pushed a commit that referenced this issue Aug 3, 2017
@Cellule
[1.7>master] [1.6>1.7] [MERGE #3469 @Cellule] WASM: reserved immediates
57c25ba 
Merge pull request #3469 from Cellule:users/micfer/wasm/reserved

Make sure reserved value are 0
Fixes #3450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cellule Cellule

Labels
Bug WebAssembly
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
1 participant
@Cellule