Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up #2751: Number#toString: add tests on the edge cases between written-out and exponential notation #3740

Closed
dilijev opened this issue Sep 15, 2017 · 0 comments
Closed

Follow-up #2751: Number#toString: add tests on the edge cases between written-out and exponential notation #3740

dilijev opened this issue Sep 15, 2017 · 0 comments
Labels
help wanted Task
Milestone
Backlog

Comments

@dilijev
Copy link
Contributor

dilijev commented Sep 15, 2017 •
edited
Loading

Follow-up to #2751 (PR #3635)

See comments on PR: #3635

/cc @xiaoyinl
@dilijev dilijev changed the title Follow-up #2751: Number#toString add tests on the edge cases between written-out and exponential notation Follow-up #2751: Number#toString: add tests on the edge cases between written-out and exponential notation Sep 15, 2017
@dilijev dilijev mentioned this issue Sep 15, 2017
Merged
@dilijev dilijev added this to the Backlog milestone Sep 15, 2017
@xiaoyinl xiaoyinl mentioned this issue Sep 15, 2017
Merged
chakrabot pushed a commit that referenced this issue Oct 21, 2017
@dilijev
[1.7>master] [MERGE #3742 @xiaoyinl] Never use exponential if radix n…
334762a 
…ot 10 (Fix #3739, #3740)

Merge pull request #3742 from xiaoyinl:never_use_exp

Other engines (SpiderMonkey, JSC and V8) never use exponential display for num.toString(radix) if radix is not 10, no matter how large num is. This PR updates the code and the test cases to match that behavior.

This PR fixes #3739 and fixes #3740.

See also: #2751, #3635.

/cc @dilijev @littledan @bterlson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Task
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@dilijev