(4h,P2) Enable (a subset of) Intl tests in Node-ChakraCore

[dilijev]

@jackhorton Some Intl.NumberFormat tests (etc.) should pass at this point, but not all tests. Depending on a variety of factors, it may not yet make sense to do this. If so, we can delay this work.

/cc @digitalinfinity

[dilijev]

Started work on this (in my Intl.NumberFormat PR #3809) and it's a bit nitpicky. As expected, some tests that should work were written to match WinGlob behavior and will need to be written to accommodate a broader range of acceptable outputs.

Here's the plan, roughly.

On Windows:

• (All Intl tests pass with WinGlob, as designed)
• With IntlICU=true build, see which tests fail.
• Split out the failing cases to their own tests files, so we have implementation-agnostic tests that pass across the board (on Windows anyway).
• Try to rewrite the remaining tests so that they pass under either WinGlob or ICU
• Otherwise write alternate versions of the tests and tag them appropriately.

Linux: basically, see where we're at after that (some modifications to the test runner may be needed). I couldn't override excluded Intl tags by saying --tags Intl (looks like the newest specified option doesn't take precedence or something like that?).

Test tags:

• We should stop excluding Intl from xplat builds built using --with-intl
• We should use tags like {require,exclude,fails}_{winglob,icu} to distinguish the state of the tests and where they should be configured to run. (where IMO the verb portions mean the following:)
  • require means it only works with that feature enabled,
  • exclude means not applicable to a config with this feature/characteristic
  • fails means it should pass but doesn't right now (i.e. disabled, and there should be a bug tracking it).

[jackhorton]

@kfarnung this is done now right?

[kfarnung]

They are enabled for Linux and Mac.

[jackhorton]

I'll call that done for the purposes for this issue.