Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake improvements #6392

Closed
ppenzin opened this issue Mar 30, 2020 · 4 comments
Closed

CMake improvements #6392

ppenzin opened this issue Mar 30, 2020 · 4 comments
Assignees

Comments

@ppenzin
Copy link
Member

ppenzin commented Mar 30, 2020

As discussed in #6384, there is value in improving CMake experience for non-MSVC developers.

I think we should provide first-class CMake build flow, in addition to the script. This should improve development experience - by using usual CMake patterns, and consolidating everything build-related "under one roof", by including testing in the build.

This should also help with integration with external projects built using CMake and various package management systems.

This was referenced Mar 30, 2020
@Fly-Style
Copy link
Contributor

I think I can help you with this issue.

@rhuanjl
Copy link
Collaborator

rhuanjl commented Mar 31, 2020

Issue #1616 has some discussion of similar points, though is probably somewhat outdate/perhaps no longer relevant - worth reviewing and combining with this issue or closing.

@ppenzin
Copy link
Member Author

ppenzin commented Apr 1, 2020

@Fly-Style Feel free to propose any other changes - you call pull my branch and update in your fork.

@rhuanjl Good point, I should have looked deeper into preexisting issues. What I am proposing is much smaller in scope. I think we do need to "refactor" #1616 into proper Github project dedicated to CMake. I will do that, unless there any objections and roll this issue in.

@ppenzin ppenzin self-assigned this Apr 1, 2020
@ppenzin
Copy link
Member Author

ppenzin commented Apr 14, 2020

I've tried following the conversation in #1616 and linked issues/PRs, but can't say I have read every post there. Big things (that CC does not yet support) that we were mentioned in that thread:

  • Full CMake builds
  • CPack (for things like Debian packages)
  • More configuration options

I've opened #6417 for the builds, we can move the CMake discussion there.

@ppenzin ppenzin closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants