Default CMake builds #6417

ppenzin · 2020-04-14T02:53:47Z

On platforms on which ChacoreCore builds via CMake allow the canonical CMake workflow. In the most basic case it would be something like this (ninja generator should be enabled as well):

$ cd build
$ cmake /path/to/ChakraCore/
$ make

(Basic workflow)

Extra credit:

testing support
expose more configuration options to the command line cmake invocation
- ICU embedding
Windows support

Windows support may be too ambitious of a goal at the moment, but projects using CMake (which we expect might embed ChakraCore) often build on Windows as well, and we should not completely rule that out.

The text was updated successfully, but these errors were encountered:

Add a direct mode for CMake builds. Add a CMake variable to distinguish between `build.sh` and direct command line use -- in direct mode the build would try to pick up reasonable system defaults. Set that variable to OFF by default and to ON in `build.sh`. ICU is not handled, for systems with no ICU installed, `-DNO_ICU=ON` would be still needed. Move DbgController.js.h generation to CMake, make that step conditional on whether dependencies have changed. Add testing under control of CMake. Invoking `check` target should run entire test suite, producing log file in the build directory. Make some CMake error messages slightly more informative. Nit: build.sh - "makefiles" is inaccurate, as it supports Ninja as well. Closes chakra-core#6417

Add a direct mode for CMake builds. Add a CMake variable to distinguish between `build.sh` and direct command line use -- in direct mode the build would try to pick up reasonable system defaults. Set that variable to OFF by default and to ON in `build.sh`. Add explicit option for Intl support for direct CMake use and set its default to `ON`. Add another explicit option for ICU include path (default to empty), also only under direct CMake. Make sure Intl setting does not get overriden. Direct CMake build would not set any explicit ICU options (aside of declaring a placeholder for its include path), this would default it to looking for system ICU. Embedding ICU from CMake is not supportec yet, but can be easily done in the future. Move DbgController.js.h generation to CMake, make that step conditional on whether dependencies have changed. Add testing under control of CMake. Invoking `check` target should run entire test suite, producing log file in the build directory. Make some CMake error messages slightly more informative. Nit: build.sh - "makefiles" is inaccurate, as it supports Ninja as well. Closes chakra-core#6417

Add a direct mode for CMake builds. Add a CMake variable to distinguish between `build.sh` and direct command line use -- in direct mode the build would try to pick up reasonable system defaults. Set that variable to OFF by default and to ON in `build.sh`. Add explicit option for Intl support for direct CMake use and set its default to `ON`. Add another explicit option for ICU include path (default to empty), also only under direct CMake. Make sure Intl setting does not get overridden. By default, direct CMake build would not set any explicit ICU options (aside of declaring a placeholder for its include path), which means it would be looking for system ICU. Embedding ICU from CMake is not supported yet, but can be easily done in the future. Move DbgController.js.h generation to CMake, make that step conditional on whether dependencies have changed. Add testing under control of CMake. Invoking `check` target should run entire test suite, producing log file in the build directory. Make some CMake error messages slightly more informative. Nit: build.sh - "makefiles" is inaccurate, as it supports Ninja as well. Closes chakra-core#6417

Add a direct mode for CMake builds. Add a CMake variable to distinguish between `build.sh` and direct command line use -- in direct mode the build would try to pick up reasonable system defaults. Set that variable to OFF by default and to ON in `build.sh`. Add explicit option for Intl support for direct CMake use and set its default to `ON`. Add another explicit option for ICU include path (default to empty), also only under direct CMake. Make sure Intl setting does not get overridden. Expose some ICU build options - embedding (default to OFF), Intl (default to ON), and ICU include path (default to empty). Move DbgController.js.h generation to CMake, make that step conditional on whether dependencies have changed. Add testing under control of CMake. Invoking `check` target should run entire test suite, producing log file in the build directory. Make some CMake error messages slightly more informative. Nit: build.sh - "makefiles" is inaccurate, as it supports Ninja as well. Closes chakra-core#6417

Add a direct mode for CMake builds. Add a CMake variable to distinguish between `build.sh` and direct command line use -- in direct mode the build would try to pick up reasonable system defaults. Set that variable to OFF by default and to ON in `build.sh`. Add explicit option for Intl support for direct CMake use and set its default to `ON`. Add another explicit option for ICU include path (default to empty), also only under direct CMake. Make sure Intl setting does not get overridden. Expose some ICU build options - embedding (default to OFF), Intl (default to ON), and ICU include path (default to empty). Move DbgController.js.h generation to CMake, make that step conditional on whether dependencies have changed. Add testing under control of CMake. Invoking `check` target should run entire test suite, producing log file in the build directory. Exclude tests dependent on ICU for non-ICU builds. Make some CMake error messages slightly more informative. Nit: build.sh - "makefiles" is inaccurate, as it supports Ninja as well. Closes chakra-core#6417

ppenzin mentioned this issue Apr 14, 2020

CMake improvements #6392

Closed

ppenzin added the Dev Experience label Apr 14, 2020

ppenzin mentioned this issue May 12, 2020

Cmake workflow #6393

Merged

rhuanjl closed this as completed in 3682e7f May 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Default CMake builds #6417

Default CMake builds #6417

ppenzin commented Apr 14, 2020 •

edited

Loading

Default CMake builds #6417

Default CMake builds #6417

Comments

ppenzin commented Apr 14, 2020 • edited Loading

ppenzin commented Apr 14, 2020 •

edited

Loading