Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myget pre-built binaries info on README #1253

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Add myget pre-built binaries info on README #1253

merged 1 commit into from
Aug 18, 2016

Conversation

liminzhu
Copy link
Collaborator

@liminzhu liminzhu commented Jul 7, 2016

Add myget pre-built binaries info on README.

@liminzhu
Copy link
Collaborator Author

liminzhu commented Jul 7, 2016

@dilijev

@dilijev
Copy link
Contributor

dilijev commented Jul 8, 2016

Looks fine to me, though I wonder if we can/should add more info about how to get the binaries from those packages. I assume most people don't know they are .zip files with a different extension.

@tcare How do we deal with NuGet packages as a means to distribute pre-built binaries, when they don't follow the NuGet package protocol?

Refer to #85 for work items to improve this.

@@ -77,6 +77,8 @@ You can build ChakraCore on Windows 7 SP1 or above, and Windows Server 2008 R2 o

More details in [Building ChakraCore](https://github.com/Microsoft/ChakraCore/wiki/Building-ChakraCore).

Alternatively, you can get pre-built ChakraCore binaries on [myget](https://www.myget.org/feed/chakracore-preview/package/nuget/Microsoft.ChakraCore).
Copy link
Contributor

@dilijev dilijev Jul 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ... pre-built ChakraCore NuGet packages containing our latest binaries from [MyGet](...?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In light of microsoft/ChakraCore-wiki#3 recommend changing this to:

Alternatively, you can get pre-built ChakraCore binaries from our [NuGet Packages](https://github.com/Microsoft/ChakraCore/wiki/NuGet-Packages).

@tcare
Copy link
Contributor

tcare commented Jul 8, 2016

Agree with Doug on basic instructions to get out the binaries.

As for Doug's concern, I would put a note that it's not in the standard layout and we'll fix that soon.

@dilijev
Copy link
Contributor

dilijev commented Jul 8, 2016

Maybe we could add a Wiki page about NuGet packages and link to it from the README. Instead of specifically mentioning the MyGet host from the README, we can just say NuGet packages are available and put the links in the Wiki page

This way, we can reduce the amount of content and churn in the README for this purpose. In the short-term, we could explain the structure and how to extract the binaries from the NuGet packages hosted on MyGet. Then, when we fix up the directory structure of the packages we can provide more info on how to integrate those dependencies and develop against them. Later, when we have an official NuGet feed, we can link to that as well.

I'll draft a PR to the Wiki about this and then we can update this PR to point to the right page.

@liminzhu
Copy link
Collaborator Author

SGTM :D.

@dilijev
Copy link
Contributor

dilijev commented Jul 26, 2016

@chakrabot chakrabot merged commit de58e5c into chakra-core:master Aug 18, 2016
chakrabot pushed a commit that referenced this pull request Aug 18, 2016
Merge pull request #1253 from liminzhu:readme

Add myget pre-built binaries info on README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants