Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to enable SemVer in binary and NuGet version numbers. #1480

Merged
merged 1 commit into from
Aug 24, 2016

Conversation

dilijev
Copy link
Contributor

@dilijev dilijev commented Aug 23, 2016

  • Provide the ability to specify all four fields of the NuGet package version (by defining environment variables in the build environment with defaults specified in init_build.ps1).
  • No longer pad binary version number segments.
  • No longer use build number in the product version number (include that information in the file version string, along with branch, commit, and build date).

@dilijev
Copy link
Contributor Author

dilijev commented Aug 23, 2016

@curtisman Need to merge this so that we can build a NuGet package from specifically the release/1.2 branch with the proper version number in the .nuspec as well as in the binaries themselves.

@dilijev dilijev changed the title Script change for NuGet version numbers. Changes to enable SemVer in binary and NuGet version numbers. Aug 24, 2016
* Provide the ability to specify all four fields of the NuGet package version (by defining environment variables in the build environment with defaults specified in init_build.ps1).
* No longer pad binary version number segments.
* No longer use build number in the product version number (include that information in the file version string, along with branch, commit, and build date).
@chakrabot chakrabot merged commit b04d804 into chakra-core:release/1.2 Aug 24, 2016
chakrabot pushed a commit that referenced this pull request Aug 24, 2016
…ersion numbers.

Merge pull request #1480 from dilijev:nuget

* Provide the ability to specify all four fields of the NuGet package version (by defining environment variables in the build environment with defaults specified in init_build.ps1).
* No longer pad binary version number segments.
* No longer use build number in the product version number (include that information in the file version string, along with branch, commit, and build date).
@dilijev dilijev deleted the nuget branch August 24, 2016 01:54
chakrabot pushed a commit that referenced this pull request Aug 24, 2016
…y and NuGet version numbers.

Merge pull request #1480 from dilijev:nuget

* Provide the ability to specify all four fields of the NuGet package version (by defining environment variables in the build environment with defaults specified in init_build.ps1).
* No longer pad binary version number segments.
* No longer use build number in the product version number (include that information in the file version string, along with branch, commit, and build date).
dilijev added a commit that referenced this pull request Aug 24, 2016
…nd NuGet version numbers.

Merge pull request #1480 from dilijev:nuget

* Provide the ability to specify all four fields of the NuGet package version (by defining environment variables in the build environment with defaults specified in init_build.ps1).
* No longer pad binary version number segments.
* No longer use build number in the product version number (include that information in the file version string, along with branch, commit, and build date).
chakrabot pushed a commit that referenced this pull request Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants