Skip to content

Conversation

@aneeshdk
Copy link
Contributor

@aneeshdk aneeshdk commented Jan 6, 2016

The build is enabled by setting the environment variable ENABLE_CODECOVERAGE. For code coveage, optimization is turned off and additional arguments are passed during linking to include more debug information.

@msftclas
Copy link

msftclas commented Jan 6, 2016

Hi @aneeshdk, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Aneesh Divakarakurup). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@aneeshdk
Copy link
Contributor Author

aneeshdk commented Jan 6, 2016

@digitalinfinity & @abchatra can you please review this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this global?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I don't understand why noopt isn't just a normal flavor and requires this hacky looking special casing. Is it not possible to make noopt work like debug release and test so that this flavPathStr variable is unnecessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it global because it is used in pre_post_util.ps1 too. Also the value can change inside other methods in the future. Noopt can be used with any flavor, so it does not exactly replace flavor string. Something like test_noopt or debug_noopt will be the more right format but I am keeping it this way for now to align with the infrastructure pieces.

@aneeshdk aneeshdk force-pushed the EnablingCodeCoverageBuild branch from 86085d8 to 34f4b92 Compare January 8, 2016 01:48
Made codecoverage to treated similar to a flavor
@aneeshdk aneeshdk force-pushed the EnablingCodeCoverageBuild branch from 34f4b92 to 3b13275 Compare January 8, 2016 01:58
@ianwjhalliday
Copy link
Collaborator

👍

@Cellule
Copy link
Contributor

Cellule commented Jan 8, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants